Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve] [broker] Part 2 of PIP-370: add metrics "pulsar_replication_disconnected_count" #23213

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

poorbarcode
Copy link
Contributor

Motivation

see also PIP-370: configurable remote topic creation in geo-replication

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.0.0 milestone Aug 23, 2024
@poorbarcode poorbarcode self-assigned this Aug 23, 2024
@github-actions github-actions bot added PIP doc-not-needed Your PR changes do not impact docs labels Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.52%. Comparing base (bbc6224) to head (2f9de9d).
Report is 543 commits behind head on master.

Files Patch % Lines
...ker/stats/prometheus/NamespaceStatsAggregator.java 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23213      +/-   ##
============================================
+ Coverage     73.57%   74.52%   +0.94%     
- Complexity    32624    34224    +1600     
============================================
  Files          1877     1922      +45     
  Lines        139502   144754    +5252     
  Branches      15299    15832     +533     
============================================
+ Hits         102638   107874    +5236     
+ Misses        28908    28622     -286     
- Partials       7956     8258     +302     
Flag Coverage Δ
inttests 27.70% <0.00%> (+3.11%) ⬆️
systests 24.68% <0.00%> (+0.36%) ⬆️
unittests 73.88% <85.71%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ker/stats/prometheus/AggregatedNamespaceStats.java 100.00% <100.00%> (ø)
...r/stats/prometheus/AggregatedReplicationStats.java 100.00% <ø> (ø)
...che/pulsar/broker/stats/prometheus/TopicStats.java 98.41% <100.00%> (+4.21%) ⬆️
...ker/stats/prometheus/NamespaceStatsAggregator.java 94.21% <80.00%> (+3.80%) ⬆️

... and 539 files with indirect coverage changes

@poorbarcode poorbarcode merged commit 09a16c2 into apache:master Aug 26, 2024
51 checks passed
poorbarcode added a commit that referenced this pull request Aug 28, 2024
…_disconnected_count" (#23213)

(cherry picked from commit 09a16c2)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2024
…_disconnected_count" (apache#23213)

(cherry picked from commit 09a16c2)
(cherry picked from commit fbf5268)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2024
…_disconnected_count" (apache#23213)

(cherry picked from commit 09a16c2)
(cherry picked from commit fbf5268)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 28, 2024
…_disconnected_count" (apache#23213)

(cherry picked from commit 09a16c2)
(cherry picked from commit fbf5268)
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants