-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix] Bump io.grpc from 1.56.0 to 1.56.1 #23276
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23276 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.97%
- Complexity 32624 34288 +1664
============================================
Files 1877 1926 +49
Lines 139502 145037 +5535
Branches 15299 15856 +557
============================================
+ Hits 102638 108123 +5485
+ Misses 28908 28646 -262
- Partials 7956 8268 +312
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mattisonchao Please share the context to others about why this is important for Pulsar. |
Pulsar is pluggable messaging system. For some plugins such as oxia metadata that is using GRPC as the RPC framework will affected by this bug. (grpc/grpc-java#10328) the bug will cause the client can't do reconnecting after hit |
(cherry picked from commit 96fd04b)
Motivation
Bump io.grpc from 1.56.0 to 1.56.1 to address this important fix. grpc/grpc-java#10328
Modifications
Verifying this change
Documentation
doc-not-needed