Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve][broker] PIP-383: Support granting/revoking permissions for multiple topics #23372

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Technoboy-
Copy link
Contributor

Motivation

PIP-383: #23355

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 29, 2024
@Technoboy- Technoboy- force-pushed the pip-383-impl branch 2 times, most recently from e0eddd1 to d18afa6 Compare September 29, 2024 11:27
@Technoboy- Technoboy- self-assigned this Sep 29, 2024
@Technoboy- Technoboy- added this to the 4.0.0 milestone Sep 29, 2024
@Technoboy- Technoboy- closed this Sep 29, 2024
@Technoboy- Technoboy- reopened this Sep 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 66.17647% with 46 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (bbc6224) to head (d18afa6).
Report is 625 commits behind head on master.

Files with missing lines Patch % Lines
...pache/pulsar/broker/admin/impl/NamespacesBase.java 55.55% 17 Missing and 3 partials ⚠️
...ker/authorization/PulsarAuthorizationProvider.java 67.44% 9 Missing and 5 partials ⚠️
...ar/broker/authorization/AuthorizationProvider.java 0.00% 4 Missing ⚠️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 75.00% 4 Missing ⚠️
.../org/apache/pulsar/broker/admin/AdminResource.java 71.42% 1 Missing and 1 partial ⚠️
...lsar/client/admin/GrantTopicPermissionOptions.java 80.00% 1 Missing ⚠️
...sar/client/admin/RevokeTopicPermissionOptions.java 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23372      +/-   ##
============================================
+ Coverage     73.57%   74.50%   +0.93%     
- Complexity    32624    34515    +1891     
============================================
  Files          1877     1936      +59     
  Lines        139502   145268    +5766     
  Branches      15299    15878     +579     
============================================
+ Hits         102638   108235    +5597     
+ Misses        28908    28721     -187     
- Partials       7956     8312     +356     
Flag Coverage Δ
inttests 27.75% <0.00%> (+3.17%) ⬆️
systests 24.47% <0.00%> (+0.15%) ⬆️
unittests 73.86% <66.17%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/authorization/AuthorizationService.java 58.52% <100.00%> (+0.32%) ⬆️
...ava/org/apache/pulsar/client/admin/Namespaces.java 66.66% <ø> (ø)
...e/pulsar/client/admin/internal/NamespacesImpl.java 97.70% <100.00%> (+2.26%) ⬆️
...lsar/client/admin/GrantTopicPermissionOptions.java 80.00% <80.00%> (ø)
...sar/client/admin/RevokeTopicPermissionOptions.java 75.00% <75.00%> (ø)
.../org/apache/pulsar/broker/admin/AdminResource.java 76.79% <71.42%> (-0.84%) ⬇️
...ar/broker/authorization/AuthorizationProvider.java 16.12% <0.00%> (-2.39%) ⬇️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 91.14% <75.00%> (+22.05%) ⬆️
...ker/authorization/PulsarAuthorizationProvider.java 68.75% <67.44%> (+0.13%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 76.23% <55.55%> (+3.15%) ⬆️

... and 597 files with indirect coverage changes

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work @Technoboy-

@Technoboy- Technoboy- merged commit b334c4f into apache:master Oct 10, 2024
51 of 52 checks passed
Technoboy- added a commit that referenced this pull request Oct 10, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants