-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][broker] Cancel possible pending replay read in cancelPendingRead #23384
Merged
rdhabalia
merged 1 commit into
apache:master
from
lhotari:lh-cancel-pending-replay-reads
Oct 1, 2024
Merged
[fix][broker] Cancel possible pending replay read in cancelPendingRead #23384
rdhabalia
merged 1 commit into
apache:master
from
lhotari:lh-cancel-pending-replay-reads
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23384 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.96%
- Complexity 32624 33967 +1343
============================================
Files 1877 1934 +57
Lines 139502 145140 +5638
Branches 15299 15870 +571
============================================
+ Hits 102638 108189 +5551
+ Misses 28908 28661 -247
- Partials 7956 8290 +334
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rdhabalia
approved these changes
Oct 1, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
apache#23384) (cherry picked from commit d2c91b1) (cherry picked from commit b940c0f)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
apache#23384) (cherry picked from commit d2c91b1) (cherry picked from commit b940c0f)
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
Jan 16, 2025
…ad in cancelPendingRead (apache#23384)" This reverts commit d2c91b1.
4 tasks
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
…ad in cancelPendingRead (apache#23384)" (apache#23855)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
…ad in cancelPendingRead (apache#23384)" (apache#23855) (cherry picked from commit ea56ada) (cherry picked from commit 7387653)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 3, 2025
…ad in cancelPendingRead (apache#23384)" (apache#23855) (cherry picked from commit ea56ada) (cherry picked from commit 7387653)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Feb 10, 2025
…ad in cancelPendingRead (apache#23384)" (apache#23855) (cherry picked from commit ea56ada)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…ad in cancelPendingRead (apache#23384)" (apache#23855)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.7
release/3.3.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's an inconsistency in the org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers#cancelPendingRead method:
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Lines 651 to 656 in e0b754d
In addition to
havePendingRead
, there's a separate fieldhavePendingReplayRead
that tracks a pending read too. It should be taken into account incancelPendingRead
method.Modifications
havePendingReplayRead
incancelPendingRead
method.Documentation
doc
doc-required
doc-not-needed
doc-complete