Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][test] Fix running ClusterMetadataSetupTest in IDE #23492

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 21, 2024

Motivation

Running ClusterMetadataSetupTest fails in IntelliJ since the tests is invalid.

Modifications

Fix the test

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Oct 21, 2024
@lhotari lhotari self-assigned this Oct 21, 2024
@lhotari lhotari requested a review from nicoloboschi October 21, 2024 13:16
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (b192d7e).
Report is 695 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23492      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.71%     
- Complexity    32624    34384    +1760     
============================================
  Files          1877     1943      +66     
  Lines        139502   146974    +7472     
  Branches      15299    16191     +892     
============================================
+ Hits         102638   109191    +6553     
- Misses        28908    29356     +448     
- Partials       7956     8427     +471     
Flag Coverage Δ
inttests 27.31% <ø> (+2.73%) ⬆️
systests 24.37% <ø> (+0.05%) ⬆️
unittests 73.66% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 653 files with indirect coverage changes

@lhotari lhotari merged commit 06471dd into apache:master Oct 21, 2024
54 of 55 checks passed
lhotari added a commit that referenced this pull request Oct 22, 2024
lhotari added a commit that referenced this pull request Oct 23, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants