[fix][test] Fix SimpleProducerConsumerTest.testMultiTopicsConsumerImplPauseForManualSubscription #23531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhaoGuorui666
changed the title
lhotari
reviewed
Oct 30, 2024
| @@ -3557,7 +3557,8 @@ public void testMultiTopicsConsumerImplPauseForManualSubscription() throws Excep | |||
| } | |||
|
|
|||
| // 6. should not consume any messages | |||
| Awaitility.await().untilAsserted(() -> assertNull(consumer.receive(RECEIVE_TIMEOUT_SECONDS, TimeUnit.SECONDS))); | |||
| Message<byte[]> msg = consumer.receive(2, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
there's already several constants for timeouts. Perhaps receive(RECEIVE_TIMEOUT_MEDIUM_MILLIS, TimeUnit.MILLISECONDS) could be used instead.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23485
Motivation
Awaitility.await().untilAsserted(() -> assertNull(consumer.receive(RECEIVE_TIMEOUT_SECONDS, TimeUnit.SECONDS)));The problem lies in this line of code. Through the logs, it can be seen that the exception situation is two calls to consumer. receive. The first call obtains null, and after the successful assertion returns, the second call will receive a message, resulting in one less total call.
Modifications
Change assertion related code
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete