Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix][broker] Increase readBuffer size for bookkeeper.DLOutputStream #23548

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #23547

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

  • This change is already covered by existing tests, such as:

    • org.apache.pulsar.packages.management.storage.bookkeeper.DLOutputStreamTest

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#33

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 4, 2024
@jiangpengcheng jiangpengcheng changed the title [fix][package] Increase readBuffer size for bookkeeper.DLOutputStream [fix][broker] Increase readBuffer size for bookkeeper.DLOutputStream Nov 4, 2024
@zymap zymap added this to the 4.1.0 milestone Nov 4, 2024
@zymap zymap requested a review from shibd November 4, 2024 11:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (bbc6224) to head (01c9629).
Report is 711 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23548      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.72%     
- Complexity    32624    34939    +2315     
============================================
  Files          1877     1943      +66     
  Lines        139502   147050    +7548     
  Branches      15299    16209     +910     
============================================
+ Hits         102638   109256    +6618     
- Misses        28908    29370     +462     
- Partials       7956     8424     +468     
Flag Coverage Δ
inttests 27.30% <100.00%> (+2.72%) ⬆️
systests 24.40% <0.00%> (+0.08%) ⬆️
unittests 73.66% <100.00%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../management/storage/bookkeeper/DLOutputStream.java 90.62% <100.00%> (-0.29%) ⬇️

... and 654 files with indirect coverage changes

@shibd shibd merged commit 7a47888 into apache:master Nov 5, 2024
52 checks passed
shibd pushed a commit that referenced this pull request Nov 5, 2024
shibd pushed a commit that referenced this pull request Nov 5, 2024
shibd pushed a commit that referenced this pull request Nov 5, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 5, 2024
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Nov 6, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 7, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] package upload will timeout when the package size is big
4 participants