-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[improve][admin] Print error log if handle http response fails #23563
Merged
Technoboy-
merged 1 commit into
apache:master
from
poorbarcode:log/client_replication_deleting_topics
Nov 6, 2024
Merged
[improve][admin] Print error log if handle http response fails #23563
Technoboy-
merged 1 commit into
apache:master
from
poorbarcode:log/client_replication_deleting_topics
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Nov 5, 2024
lhotari
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23563 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
- Complexity 32624 34327 +1703
============================================
Files 1877 1943 +66
Lines 139502 147056 +7554
Branches 15299 16210 +911
============================================
+ Hits 102638 109310 +6672
- Misses 28908 29327 +419
- Partials 7956 8419 +463
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 6, 2024
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
poorbarcode
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit c15a0d6)
poorbarcode
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit c15a0d6)
poorbarcode
added a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit c15a0d6)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2024
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 13, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When users are calling
pulsar-admin
API, and there is an internal error( such as a deserialize JSON error), there is no error log.You can test it this way:
TopicStatsImpl
, and return aString
value(such asabc
), which will make theresponse.msgRateIn
as a String valueabc
.pulsar-admin topics stats
Modifications
Print error log if handle HTTP response fails
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x