-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][misc] Class conflict during jetcd-core-shaded shading process #23641
Merged
lhotari
merged 1 commit into
apache:master
from
Shawyeok:fix-jetcd-core-shading-issue-2
Nov 26, 2024
Merged
[fix][misc] Class conflict during jetcd-core-shaded shading process #23641
lhotari
merged 1 commit into
apache:master
from
Shawyeok:fix-jetcd-core-shading-issue-2
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to execute shade multiple times without clean
lhotari
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good work @Shawyeok. Thanks for finding the root cause and addressing the problem.
@Shawyeok Please submit a similar PR to BookKeeper for jetcd-core-shaded. |
@lhotari |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…pache#23641) (cherry picked from commit 3e108da) (cherry picked from commit 6c33bf1)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…pache#23641) (cherry picked from commit 3e108da) (cherry picked from commit 6c33bf1)
4 tasks
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
release/3.0.8
release/3.3.3
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the latest release candidates (
3.0.8-candidate-1
,4.0.1-candidate-1
), the jetcd-core-shaded module shading issue persists. This occurs because themaven-shade-plugin
includes the current project artifact in the shade process. Injetcd-core-shaded
, we copyio.etcd.jetcd.*
into thejetcd-core-shaded
jar without relocation. As a result, when theinstall
ordeploy
goals are executed without cleaning thetarget
folder, class conflicts arise betweenio.etcd.jetcd.*
insideorg.apache.pulsar:jetcd-core-shaded.jar
andio.etcd:jetcd-core.jar
.#23604 attempted to resolve this issue but failed to account for build and deploy in separate steps during the release process.
Verifying this Change
To verify this patch, follow these steps:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: Shawyeok#20