Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore #23653

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Nov 28, 2024

Motivation

  • oxia-java 0.4.10 switches from javax.annotation to jakarta.annotation
  • OxiaMetadataStore close isn't properly changing the state to closed

Modifications

  • upgrade to oxia-java 0.4.10
  • fix OxiaMetadataStore.close

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.1.0 milestone Nov 28, 2024
@lhotari lhotari self-assigned this Nov 28, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (bbc6224) to head (c92d529).
Report is 767 commits behind head on master.

Files with missing lines Patch % Lines
...e/pulsar/metadata/impl/oxia/OxiaMetadataStore.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23653      +/-   ##
============================================
+ Coverage     73.57%   74.34%   +0.76%     
- Complexity    32624    35008    +2384     
============================================
  Files          1877     1944      +67     
  Lines        139502   147239    +7737     
  Branches      15299    16250     +951     
============================================
+ Hits         102638   109460    +6822     
- Misses        28908    29335     +427     
- Partials       7956     8444     +488     
Flag Coverage Δ
inttests 27.19% <50.00%> (+2.61%) ⬆️
systests 24.31% <0.00%> (-0.01%) ⬇️
unittests 73.73% <75.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/pulsar/metadata/impl/oxia/OxiaMetadataStore.java 87.83% <75.00%> (-2.17%) ⬇️

... and 661 files with indirect coverage changes

@lhotari lhotari changed the title [improve][metadata] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore [improve] Upgrade oxia-java to 0.4.10 and fix closing of OxiaMetadataStore Nov 28, 2024
@lhotari lhotari merged commit 7e6fa55 into apache:master Nov 28, 2024
54 of 59 checks passed
lhotari added a commit that referenced this pull request Nov 28, 2024
lhotari added a commit that referenced this pull request Nov 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants