-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[feat][broker] Implement allowBrokerOperationAsync in PulsarAuthorizationProvider to avoid exception thrown #23663
Merged
lhotari
merged 3 commits into
apache:master
from
mattisonchao:feat.support.allowTopicPolicyOperationAsync
Nov 29, 2024
Merged
[feat][broker] Implement allowBrokerOperationAsync in PulsarAuthorizationProvider to avoid exception thrown #23663
lhotari
merged 3 commits into
apache:master
from
mattisonchao:feat.support.allowTopicPolicyOperationAsync
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23663 +/- ##
============================================
+ Coverage 73.57% 74.36% +0.78%
- Complexity 32624 34508 +1884
============================================
Files 1877 1944 +67
Lines 139502 147328 +7826
Branches 15299 16257 +958
============================================
+ Hits 102638 109558 +6920
- Misses 28908 29304 +396
- Partials 7956 8466 +510
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…tionProvider to avoid exception thrown (apache#23663)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/broker
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.3.4
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#23637 introduces a method called
allowTopicPolicyOperationAsync
. Although we kept the compatibility, the exception thrown will cost more CPU and give GC pressure.Modifications
PulsarAuthorizationProvider
Verifying this change
The existing test
BrokerEndpointsAuthorizationTest
is already covered.Make sure that the change passes the CI checks.
Documentation
doc-not-needed