-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix][common] TopicName: Throw IllegalArgumentException if localName is whitespace only #23691
Merged
Technoboy-
merged 2 commits into
apache:master
from
pdolif:fix-blank-localname-in-topic-name
Dec 17, 2024
Merged
[fix][common] TopicName: Throw IllegalArgumentException if localName is whitespace only #23691
Technoboy-
merged 2 commits into
apache:master
from
pdolif:fix-blank-localname-in-topic-name
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Dec 8, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dao-jun
approved these changes
Dec 11, 2024
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23691 +/- ##
============================================
+ Coverage 73.57% 73.75% +0.17%
- Complexity 32624 34285 +1661
============================================
Files 1877 1945 +68
Lines 139502 150723 +11221
Branches 15299 17033 +1734
============================================
+ Hits 102638 111160 +8522
- Misses 28908 30971 +2063
- Partials 7956 8592 +636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Dec 17, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…is whitespace only (apache#23691) (cherry picked from commit 034791f) (cherry picked from commit 0e4dbd1)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…is whitespace only (apache#23691) (cherry picked from commit 034791f) (cherry picked from commit 0e4dbd1)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…is whitespace only (apache#23691)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
release/3.0.9
release/3.3.4
release/4.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23690
Motivation
When creating a consumer with the topic name only being a whitespace we get:
That's why I expect
TopicName.get(" ")
to throw an exception too.Modifications
Throw exception if
localName
is blank.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: pdolif#5