-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[improve][txn] Improve Reader in TransactionBuffer to reduce GC pressure #23779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23779 +/- ##
============================================
+ Coverage 73.57% 74.12% +0.54%
+ Complexity 32624 32125 -499
============================================
Files 1877 1853 -24
Lines 139502 143379 +3877
Branches 15299 16276 +977
============================================
+ Hits 102638 106274 +3636
+ Misses 28908 28721 -187
- Partials 7956 8384 +428
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
Jan 3, 2025
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
area/broker
area/transaction
category/performance
Performance issues fix or improvements
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/4.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the reader referenced by TransactionBuffer pooling messages to reduce GC pressure.
If
poolMessage=false
of the Reader, pulsar client will copy message payload into heap without pooling.Generally, it is not recommended to users use the feature, because it requires call
message.release()
manually, or it will lead to mem leak.However, in the broker side, we need this feature to improve JVM GC performance.
Especially for there is a big number of topics served by a single broker.
Modifications
poolMessage=true
when TopicTransactionBuffer component creating a readermessage.release()
manually after process messages.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete