DISPATCH-1363 - Move RAT licence check from travis builds into a sub build

[jirkadanek]

Now easier to do when the matrix key is in place in .travis.yml.

Doing this also fixes the duplicated top level cache key in .travis.yml we had.

It appears that matrix is outdated syntax, and jobs should be preferred, travis-ci/docs-travis-ci-com#1500. The doc page https://docs.travis-ci.com/user/customizing-the-build/#Build-Matrix uses matrix.include in the text and jobs.include in the yaml samples. Task for another time.

[jirkadanek]

@ganeshmurthy Is this what you've had in mind?

[ganeshmurthy]

@jdanekrh can you please rebase this PR with master and simply add a file with no license so that the RAT check fails? This is what I would like to see. If the RAT check fails, there should be a red X mark next to the checkin. When I click on the X mark I should be taken to a page which shows all builds passing but only the RAT failing (this is already happening).

[jirkadanek]

Here, https://travis-ci.org/jdanekrh/qpid-dispatch/builds/599323593

[jirkadanek]

And the PR here #593

[ganeshmurthy]

@jdanekrh ok thanks, I will wait for the builds to complete and check back in an hour or so to see how things have worked out. Will keep you posted.

[codecov-io]

Codecov Report

Merging #592 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files          90       90              
  Lines       20484    20483       -1     
==========================================
- Hits        17691    17689       -2     
- Misses       2793     2794       +1

Impacted Files	Coverage Δ
src/router_core/transfer.c	93.26% <0%> (-0.5%)	⬇️
src/router_core/connections.c	93.86% <0%> (-0.12%)	⬇️
src/message.c	90.99% <0%> (-0.1%)	⬇️
src/router_node.c	93.14% <0%> (+0.12%)	⬆️
src/iterator.c	89.51% <0%> (+0.16%)	⬆️
src/container.c	81.37% <0%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2339c41...d2930ea. Read the comment docs.

[jirkadanek]

@ganeshmurthy is Travis usually this slow during US work hours?

[ganeshmurthy]

@ganeshmurthy is Travis usually this slow during US work hours?

@jdanekrh It has been slow the past couple of days but usually it is pretty good.

[gemmellr]

The Travis rsources under /apache are shared for the entire ASF, so it depends what other projects have done, e.g if anyone is overly [ab]using the resources at a given time.

Though these are only very small jobs by comparison to many, it still helps not to use branches in the main repo simply for testing variants of changes. You can enable and run Travis on your own repo fork (which is served from a far larger resource pool, and so is typically very fast to start building) and push to / pull request against the main repo only when you think its ready.