fix dledger recover abnormally may lost consume queue of tail #7599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuz10
previously approved these changes
Jan 16, 2024
yuz10
reviewed
Jan 16, 2024
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
Outdated
Show resolved
Hide resolved
yuz10
reviewed
Jan 18, 2024
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7599 +/- ##
=============================================
- Coverage 43.19% 43.18% -0.02%
- Complexity 9782 9828 +46
=============================================
Files 1162 1167 +5
Lines 84378 84690 +312
Branches 10955 10993 +38
=============================================
+ Hits 36451 36572 +121
- Misses 43397 43570 +173
- Partials 4530 4548 +18 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fix #7355
Brief Description
rocketmq in dledger mode will recover correctly from an abnormal downtime
How Did You Test This Change?
Run DLedgerCommitlogTest.testDLedgerAbnormallyRecover()