Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #7644] Optimize client rebalance #7645

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Dec 12, 2023

Which Issue(s) This PR Fixes

Fixes #7644

Brief Description

  • Add tryRebalance for return value
  • Optimize order rebalance performance
  • Add rebalanceImmediately when offset illegal

How Did You Test This Change?

@drpmma drpmma changed the title [ISSUE #7644] Optimize rebalance [ISSUE #7644] Optimize client rebalance Dec 12, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (c2c29c2) 43.20% compared to head (bd6b4b8) 43.21%.
Report is 7 commits behind head on develop.

Files Patch % Lines
...cketmq/client/impl/consumer/RebalancePushImpl.java 0.00% 18 Missing ⚠️
...apache/rocketmq/store/timer/TimerMessageStore.java 20.00% 4 Missing ⚠️
...apache/rocketmq/broker/slave/SlaveSynchronize.java 0.00% 3 Missing ⚠️
...lient/impl/consumer/DefaultMQPullConsumerImpl.java 0.00% 3 Missing ⚠️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java 40.00% 1 Missing and 2 partials ⚠️
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 50.00% 1 Missing and 2 partials ⚠️
...pache/rocketmq/common/message/MessageAccessor.java 0.00% 3 Missing ⚠️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7645      +/-   ##
=============================================
+ Coverage      43.20%   43.21%   +0.01%     
- Complexity      9796     9818      +22     
=============================================
  Files           1164     1165       +1     
  Lines          84420    84486      +66     
  Branches       10961    10970       +9     
=============================================
+ Hits           36474    36512      +38     
- Misses         43420    43451      +31     
+ Partials        4526     4523       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma self-assigned this Dec 21, 2023
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 59e8f9b into apache:develop Dec 27, 2023
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize client rebalance
5 participants