[ISSUE #7651] Support to send trace for batchSend #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7652 +/- ##
=============================================
- Coverage 43.19% 42.82% -0.37%
- Complexity 9812 10355 +543
=============================================
Files 1165 1270 +105
Lines 84461 88670 +4209
Branches 10964 11404 +440
=============================================
+ Hits 36482 37976 +1494
- Misses 43454 46003 +2549
- Partials 4525 4691 +166 ☔ View full report in Codecov by Sentry. |
cserwen
force-pushed
the
batch_send_trace
branch
3 times, most recently
from
87d3276 to
dc252f8
Compare
|
LGTM~ |
humkum
approved these changes
Jan 11, 2024
|
LGTM There will be significant improvement in the performance of the trajectory. |
Need to approve it, lol @leizhiyuan |
lizhimins
changed the title
lizhimins
reviewed
Feb 23, 2024
client/src/main/java/org/apache/rocketmq/client/trace/hook/SendMessageTraceHookImpl.java
Show resolved
Hide resolved
|
@lizhimins Please help me review this code :-D |
cserwen
force-pushed
the
batch_send_trace
branch
from
dc252f8 to
d8cc24d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7651
Brief Description
Make SendMessageTraceHookImpl support processing batch messages
How Did You Test This Change?
unit-test