Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #9111] Support export broker RocksDB Config to json file #9114

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9111

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 12.06030% with 175 lines in your changes missing coverage. Please review.

Project coverage is 47.89%. Comparing base (0548593) to head (03436fa).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...s/command/metadata/RocksDBConfigToJsonCommand.java 0.00% 112 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 3.22% 30 Missing ⚠️
...header/ExportRocksDBConfigToJsonRequestHeader.java 70.96% 8 Missing and 1 partial ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 8 Missing ⚠️
...broker/config/v1/RocksDBConsumerOffsetManager.java 16.66% 5 Missing ⚠️
...ker/config/v1/RocksDBSubscriptionGroupManager.java 0.00% 3 Missing ⚠️
...mq/broker/config/v1/RocksDBTopicConfigManager.java 0.00% 3 Missing ⚠️
...apache/rocketmq/tools/admin/DefaultMQAdminExt.java 0.00% 2 Missing ⚠️
...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java 0.00% 2 Missing ⚠️
...command/export/ExportMetadataInRocksDBCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9114      +/-   ##
=============================================
- Coverage      47.94%   47.89%   -0.05%     
- Complexity     12037    12045       +8     
=============================================
  Files           1320     1321       +1     
  Lines          92827    93021     +194     
  Branches       11897    11925      +28     
=============================================
+ Hits           44507    44557      +50     
- Misses         42809    42949     +140     
- Partials        5511     5515       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin
Copy link
Contributor

I think we can remove the ExportMetadataInRocksDBCommand, as this command duplicates the functionality of RocksDBConfigToJsonCommand command.

@qianye1001 qianye1001 force-pushed the issue9111 branch 2 times, most recently from 03a3a6e to eca3645 Compare January 13, 2025 06:02
Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit b30afe8 into apache:develop Jan 14, 2025
10 of 11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support export json consumer offset to file when using RocksDB consumer offset manage
5 participants