Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fail to parsing PostgreSQL due to the quotation #993

Closed
finger92 opened this issue Jul 10, 2018 · 4 comments
Closed

Fail to parsing PostgreSQL due to the quotation #993

finger92 opened this issue Jul 10, 2018 · 4 comments
Assignees

Comments

@finger92
Copy link

For English only, other languages we will close it directly.

Please answer these questions before submitting your issue. Thanks!

Which version of Sharding-Sphere do you using?

3.0.0.M1

Expected behavior

correctly parsing sql (select * from "t_user")

Actual behavior

sql after parsing was "select * from "tt_user"

Steps to reproduce the behavior

Please provide the reproduce example codes (such as a github link).

@tuohai666
Copy link
Member

Suspending.
To fix this bug we need to change the structure of SS Parser, it is not worth it.
Fortunately, a new SS Parser will coming later, and let's come back to this issue that time.

@tuohai666
Copy link
Member

Need to discuss with Liang.

@tuohai666
Copy link
Member

Surprise!
Fixed.

terrymanu added a commit that referenced this issue Jul 25, 2018
for #993, distinguish PostgreSQL from other databases when parsing Identifier and Chars
@terrymanu terrymanu changed the title fail to parsing postgresql due to the quotation Fail to parsing postgresql due to the quotation Aug 8, 2018
@terrymanu terrymanu changed the title Fail to parsing postgresql due to the quotation Fail to parsing PostgreSQL due to the quotation Aug 8, 2018
@terrymanu
Copy link
Member

fixed at 3.0.0.M2

@tuohai666 tuohai666 self-assigned this Jan 18, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants