Support connecting to HiveServer2 with ZooKeeper Service Discovery enabled in GraalVM Native Image #33768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
changed the title
linghengqian
force-pushed
the
hive-graalvm
branch
3 times, most recently
from
738821b to
c1c6527
Compare
…abled in GraalVM Native Image
linghengqian
force-pushed
the
hive-graalvm
branch
from
c1c6527 to
e12ffba
Compare
linghengqian
commented
Nov 23, 2024
Comment on lines
+123
to
+137
| int randomPortSecond = InstanceSpec.getRandomPort(); | ||
| try ( | ||
| GenericContainer<?> hiveServer2SecondContainer = new FixedHostPortGenericContainer<>("apache/hive:4.0.1") | ||
| .withNetwork(NETWORK) | ||
| .withEnv("SERVICE_NAME", "hiveserver2") | ||
| .withEnv("SERVICE_OPTS", "-Dhive.server2.support.dynamic.service.discovery=true" + " " | ||
| + "-Dhive.zookeeper.quorum=" + ZOOKEEPER_CONTAINER.getNetworkAliases().get(0) + ":2181" + " " | ||
| + "-Dhive.server2.thrift.bind.host=0.0.0.0" + " " | ||
| + "-Dhive.server2.thrift.port=" + randomPortSecond) | ||
| .withFixedExposedPort(randomPortSecond, randomPortSecond) | ||
| .dependsOn(ZOOKEEPER_CONTAINER)) { | ||
| hiveServer2SecondContainer.start(); | ||
| extracted(hiveServer2SecondContainer.getMappedPort(randomPortSecond)); | ||
| testShardingService.processSuccessInHive(); | ||
| } |
There was a problem hiding this comment.
- Let me investigate a bit on the testcontainers side first. See [Feature]: Add an annotation similar to
@org.testcontainers.junit.jupiter.Containerto theorg.testcontainers.containers.Networkclass testcontainers/testcontainers-java#9552 and [Feature]: Add a method toGenericContainerto expose a random container port with the same number as the host port testcontainers/testcontainers-java#9553 .
This was referenced Nov 23, 2024
terrymanu
approved these changes
Nov 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.