Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support GroupConcat sql for aggregating multiple shards(#33797) #33808

Merged
merged 26 commits into from
Dec 6, 2024

Conversation

YaoFly
Copy link
Contributor

@YaoFly YaoFly commented Nov 26, 2024

Fixes #33797.

Changes proposed in this pull request:

  • Support GroupConcat sql for aggregating multiple shards
  • Support GroupConcat sql for default separator

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@YaoFly
Copy link
Contributor Author

YaoFly commented Nov 28, 2024

@strongduanmu PTAL. I don't think my changes will affect the "E2E - Operation / E2E - pipeline on postgres:12-alpine (pull_request) ",

@strongduanmu
Copy link
Member

strongduanmu commented Nov 28, 2024

Hi @YaoFly, can you add e2e test in https://github.com/apache/shardingsphere/blob/master/test/e2e/sql/src/test/resources/cases/dql/e2e-dql-select-aggregate.xml

Another question is, besides MySQL database, are there any other databases that support GROUP_CONCAT? If so, please add them to the E2E Case.

@YaoFly
Copy link
Contributor Author

YaoFly commented Nov 28, 2024

Hi @YaoFly, can you add e2e test in https://github.com/apache/shardingsphere/blob/master/test/e2e/sql/src/test/resources/cases/dql/e2e-dql-select-aggregate.xml

Another question is, besides MySQL database, are there any other databases that support GROUP_CONCAT? If so, please add them to the E2E Case.

ok, I will

@YaoFly
Copy link
Contributor Author

YaoFly commented Dec 2, 2024

Hi @YaoFly, can you add e2e test in https://github.com/apache/shardingsphere/blob/master/test/e2e/sql/src/test/resources/cases/dql/e2e-dql-select-aggregate.xml

Another question is, besides MySQL database, are there any other databases that support GROUP_CONCAT? If so, please add them to the E2E Case.

e2e test added. besides MySQL database, other database required additional code development, which I suggest supporting them in other pull requests?

@strongduanmu
Copy link
Member

Hi @YaoFly, can you add e2e test in https://github.com/apache/shardingsphere/blob/master/test/e2e/sql/src/test/resources/cases/dql/e2e-dql-select-aggregate.xml
Another question is, besides MySQL database, are there any other databases that support GROUP_CONCAT? If so, please add them to the E2E Case.

e2e test added. besides MySQL database, other database required additional code development, which I suggest supporting them in other pull requests?

OK, you are welcome to submit more PRs to support other database.

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YaoFly, thanks for everything you did on this PR, it still has some minor issues that need your help.

@strongduanmu
Copy link
Member

@YaoFly In addition, you need to update this PR to the RELEASE-NOTE of 5.5.2-SNAPSHOT.

@strongduanmu
Copy link
Member

@YaoFly From this PR, we can see that you are familiar with ShardingSphere. If you want to further participate in the development, you can send me your WeChat and I may be able to provide you with more help.

@YaoFly
Copy link
Contributor Author

YaoFly commented Dec 3, 2024

@YaoFly From this PR, we can see that you are familiar with ShardingSphere. If you want to further participate in the development, you can send me your WeChat and I may be able to provide you with more help.

wx id : yaoflycn

@YaoFly YaoFly requested a review from strongduanmu December 4, 2024 08:00
@YaoFly YaoFly requested a review from strongduanmu December 5, 2024 09:03
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so great, merged.

@strongduanmu strongduanmu merged commit f17f89e into apache:master Dec 6, 2024
147 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GroupConcat sql for aggregating multiple shards
2 participants