Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[type: security]fix shenyu-admin: add dashboard user permission #2357

Merged
merged 9 commits into from
Nov 16, 2021

Conversation

midnight2104
Copy link
Contributor

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #2357 (e633991) into master (4ade51c) will decrease coverage by 0.03%.
The diff coverage is 64.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2357      +/-   ##
============================================
- Coverage     58.13%   58.09%   -0.04%     
+ Complexity     3951     3948       -3     
============================================
  Files           629      629              
  Lines         18044    18059      +15     
  Branches       1695     1695              
============================================
+ Hits          10489    10492       +3     
- Misses         6719     6727       +8     
- Partials        836      840       +4     
Impacted Files Coverage Δ
.../apache/shenyu/admin/model/vo/DashboardUserVO.java 74.50% <ø> (ø)
.../shenyu/admin/service/impl/AppAuthServiceImpl.java 82.58% <ø> (ø)
...che/shenyu/admin/service/impl/EnumServiceImpl.java 100.00% <ø> (ø)
...shenyu/admin/service/impl/MetaDataServiceImpl.java 5.26% <0.00%> (+0.05%) ⬆️
...e/shenyu/admin/service/impl/PluginServiceImpl.java 84.55% <0.00%> (-2.12%) ⬇️
...e/shenyu/admin/shiro/bean/StatelessAuthFilter.java 6.06% <ø> (ø)
...g/apache/shenyu/admin/shiro/config/ShiroRealm.java 14.81% <0.00%> (ø)
...apache/shenyu/admin/utils/ShenyuResultMessage.java 0.00% <ø> (ø)
...henyu/admin/service/impl/UpstreamCheckService.java 27.20% <18.18%> (-0.45%) ⬇️
...enyu/admin/service/impl/PermissionServiceImpl.java 80.95% <64.70%> (-1.55%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ade51c...e633991. Read the comment docs.

@yu199195 yu199195 merged commit 0e826ce into master Nov 16, 2021
@yu199195 yu199195 changed the title fix shenyu-admin: add dashboard user permission [type: security]fix shenyu-admin: add dashboard user permission Nov 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants