-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Inject skywalking context. #107
Conversation
Should we consider the whole trace context? |
$serviceName, $instanceName, $traceId, $traceSegmentId are injected. |
How about $spanId? |
And please update the docs according, after you added the span ID. |
$spanId should not be for the entire request, right? |
It is not. It is variable according to span creation and stop status. |
I would like to implement $spanId in the future (if there is user demand) |
If that is the case, please remove segmentId as well, that is useless without span ID. Both IDs lock the specific span. |
apache/skywalking#11885