Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inject skywalking context. #107

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Inject skywalking context. #107

merged 5 commits into from
Feb 21, 2024

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Feb 20, 2024

@jmjoy jmjoy added the enhancement New feature or request label Feb 20, 2024
@jmjoy jmjoy added this to the 0.8.0 milestone Feb 20, 2024
@jmjoy jmjoy requested review from heyanlong and wu-sheng February 20, 2024 03:12
@jmjoy jmjoy self-assigned this Feb 20, 2024
@wu-sheng
Copy link
Member

Should we consider the whole trace context?

heyanlong
heyanlong previously approved these changes Feb 20, 2024
@jmjoy
Copy link
Member Author

jmjoy commented Feb 20, 2024

Should we consider the whole trace context?

$serviceName, $instanceName, $traceId, $traceSegmentId are injected.

@wu-sheng
Copy link
Member

Should we consider the whole trace context?

$serviceName, $instanceName, $traceId, $traceSegmentId are injected.

How about $spanId?

@wu-sheng
Copy link
Member

And please update the docs according, after you added the span ID.

@jmjoy
Copy link
Member Author

jmjoy commented Feb 21, 2024

How about $spanId?

$spanId should not be for the entire request, right?

@wu-sheng
Copy link
Member

How about $spanId?

$spanId should not be for the entire request, right?

It is not. It is variable according to span creation and stop status.

@jmjoy
Copy link
Member Author

jmjoy commented Feb 21, 2024

$spanId should not be for the entire request, right?

It is not. It is variable according to span creation and stop status.

I would like to implement $spanId in the future (if there is user demand)

@wu-sheng
Copy link
Member

$spanId should not be for the entire request, right?

It is not. It is variable according to span creation and stop status.

I would like to implement $spanId in the future (if there is user demand)

If that is the case, please remove segmentId as well, that is useless without span ID. Both IDs lock the specific span.

@wu-sheng wu-sheng merged commit c23e76a into apache:master Feb 21, 2024
18 checks passed
@jmjoy jmjoy deleted the inject-context branch February 21, 2024 02:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants