Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Report instance properties and keep alive. #46

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jan 19, 2023

  1. Report instance properties and keep alive.
  2. Clearly limit the version of Skywalking (>= 8).

@jmjoy jmjoy added this to the 0.3.0 milestone Jan 19, 2023
@jmjoy jmjoy marked this pull request as ready for review January 19, 2023 09:42
@jmjoy jmjoy requested review from heyanlong and wu-sheng January 19, 2023 09:42
@wu-sheng wu-sheng merged commit 384564f into apache:master Jan 19, 2023
@jmjoy jmjoy deleted the management branch January 19, 2023 09:46
@Superskyyy
Copy link
Member

I just saw this and remembered agents were supposed to resubmit instance properties periodically as the OAP TTL mechanism would purge them. Is it still true? @wu-sheng

@wu-sheng
Copy link
Member

Yes, you are correct. I totally forgot this. 😅

@Superskyyy
Copy link
Member

Superskyyy commented Jan 20, 2023

Yes, you are correct. I totally forgot this. 😅

😄 @jmjoy FYI the instance property will require a periodical update.

Refer to Java agent here:
https://github.dev/apache/skywalking-java/blob/f366503d58aa7e3395d88f6c70e6ea885fc50d2e/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/ServiceManagementClient.java#L105

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants