Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Log Exception in tracing span when throw. #75

Merged
merged 2 commits into from
May 20, 2023
Merged

Log Exception in tracing span when throw. #75

merged 2 commits into from
May 20, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented May 18, 2023

  1. Log Exception after calling the hooked function/method, if it throw.

    image

  2. Add PDO::__construct and mysqli::__construct in spans, because they are possible to throw Exception.

@jmjoy jmjoy added this to the 0.6.0 milestone May 18, 2023
@jmjoy jmjoy marked this pull request as ready for review May 18, 2023 12:32
@jmjoy jmjoy marked this pull request as draft May 19, 2023 01:25
@jmjoy jmjoy marked this pull request as ready for review May 20, 2023 02:18
@jmjoy jmjoy merged commit a4e6baa into apache:master May 20, 2023
@jmjoy jmjoy deleted the ex branch May 20, 2023 02:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jmjoy @wu-sheng