Support MacOS by repalce ipc-channel with socketpair, upgrade dependencies and improve CI. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Sep 7, 2022
kezhenxu94
reviewed
Sep 7, 2022
jmjoy
changed the title
jmjoy
commented
Sep 10, 2022
Comment on lines
+162
to
+165
| - name: View logs | ||
| if: always() | ||
| run: | | ||
| cat /tmp/*.log |
There was a problem hiding this comment.
@kezhenxu94 Is this step correct? I want to perform this step regardless of whether the previous step is successful or not.
wu-sheng
approved these changes
Sep 10, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phper, with macos compat.required_status_checksto.asf.yaml.ipc-channelwith stdUnixDatagram::pair, because there are some bugs inipc-channelwhen target os is MacOS.