-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[SPARK-39099][BUILD] Add dependencies to Dockerfile for building Spark releases #36449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
[WIP][SPARK-39099][BUILD] Add dependencies to Dockerfile for building Spark releases
[SPARK-39099][BUILD] Add dependencies to Dockerfile for building Spark releases
May 5, 2022
cloud-fan
approved these changes
May 5, 2022
Merging to master/3.3. @cloud-fan Thank you for review. |
MaxGekk
added a commit
that referenced
this pull request
May 5, 2022
…k releases ### What changes were proposed in this pull request? Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`. ### Why are the changes needed? To be able to build Spark releases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By building the Spark 3.3 release via: ``` $ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1 ``` Closes #36449 from MaxGekk/deps-Dockerfile. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 4b1c2fb) Signed-off-by: Max Gekk <max.gekk@gmail.com>
Thank you, @MaxGekk ! |
HyukjinKwon
reviewed
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I backported this to |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 11, 2022
…k releases Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`. To be able to build Spark releases. No. By building the Spark 3.3 release via: ``` $ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1 ``` Closes #36449 from MaxGekk/deps-Dockerfile. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 4b1c2fb) Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 6a61f95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…k releases Add missed dependencies to `dev/create-release/spark-rm/Dockerfile`. To be able to build Spark releases. No. By building the Spark 3.3 release via: ``` $ dev/create-release/do-release-docker.sh -d /home/ubuntu/max/spark-3.3-rc1 ``` Closes apache#36449 from MaxGekk/deps-Dockerfile. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 4b1c2fb) Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit 6a61f95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add missed dependencies to
dev/create-release/spark-rm/Dockerfile
.Why are the changes needed?
To be able to build Spark releases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By building the Spark 3.3 release via: