[SPARK-49824][SS][CONNECT] Improve logging in SparkConnectStreamingQueryCache #48293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonwang-db
approved these changes
Oct 3, 2024
HyukjinKwon
approved these changes
Oct 3, 2024
|
Merged to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…eryCache ### What changes were proposed in this pull request? The query key in the cache is <id, runId> but in the log only the id is logged. A query could have the same id but different runid, we need to log both id and runid to make it less confusing. ### Why are the changes needed? Debug improvement ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check log ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48293 from WweiL/listener-cache-improvement. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The query key in the cache is <id, runId> but in the log only the id is logged. A query could have the same id but different runid, we need to log both id and runid to make it less confusing.
Why are the changes needed?
Debug improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual check log
Was this patch authored or co-authored using generative AI tooling?
No