Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

required polyfills for older browser support #1302

Closed
gschrader opened this issue Oct 9, 2016 · 5 comments
Closed

required polyfills for older browser support #1302

gschrader opened this issue Oct 9, 2016 · 5 comments

Comments

@gschrader
Copy link
Contributor

I found that adding Object.assign and Array.prototype.includes polyfills I was able to get an older browser to work that I need to be able to support. This might also address #1201 I haven't had a chance to test IE yet.

I'm wondering if this is something that should be added to the project or if I should just patch my installs. I can raise a PR, I'm just not sure the best place to add them. Any thoughts?

@xrmx xrmx added the javascript label Oct 9, 2016
@xrmx
Copy link
Contributor

xrmx commented Oct 9, 2016

A PR would be appreciated of course, regarding the place to add them i suppose just add them as npm dependencies like the others js libraries and require them where needed?

@gschrader
Copy link
Contributor Author

I think polyfills have to be global but I'll give it a try.

@ascott
Copy link

ascott commented Oct 11, 2016

@gschrader what browser are you trying to support?

@gschrader
Copy link
Contributor Author

@ascott It's the javafx webview browser, which I believe is based on an old version of webkit.

@gschrader
Copy link
Contributor Author

I can confirm #1323 works with the javafx webview, thanks again @ascott

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
…ng when not rich tooltip (apache#1302)

* fix(plugin-chart-echarts): fix Time-series line x-filtering not working

* fix: fix emphasis

* fix: size
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
…ng when not rich tooltip (apache#1302)

* fix(plugin-chart-echarts): fix Time-series line x-filtering not working

* fix: fix emphasis

* fix: size
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
…ng when not rich tooltip (apache#1302)

* fix(plugin-chart-echarts): fix Time-series line x-filtering not working

* fix: fix emphasis

* fix: size
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
…ng when not rich tooltip (apache#1302)

* fix(plugin-chart-echarts): fix Time-series line x-filtering not working

* fix: fix emphasis

* fix: size
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants