-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
required polyfills for older browser support #1302
Comments
A PR would be appreciated of course, regarding the place to add them i suppose just add them as npm dependencies like the others js libraries and require them where needed? |
I think polyfills have to be global but I'll give it a try. |
Closed
@gschrader what browser are you trying to support? |
@ascott It's the javafx webview browser, which I believe is based on an old version of webkit. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 17, 2021
…ng when not rich tooltip (apache#1302) * fix(plugin-chart-echarts): fix Time-series line x-filtering not working * fix: fix emphasis * fix: size
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 24, 2021
…ng when not rich tooltip (apache#1302) * fix(plugin-chart-echarts): fix Time-series line x-filtering not working * fix: fix emphasis * fix: size
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 25, 2021
…ng when not rich tooltip (apache#1302) * fix(plugin-chart-echarts): fix Time-series line x-filtering not working * fix: fix emphasis * fix: size
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this issue
Nov 26, 2021
…ng when not rich tooltip (apache#1302) * fix(plugin-chart-echarts): fix Time-series line x-filtering not working * fix: fix emphasis * fix: size
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
I found that adding
Object.assign
andArray.prototype.includes
polyfills I was able to get an older browser to work that I need to be able to support. This might also address #1201 I haven't had a chance to test IE yet.I'm wondering if this is something that should be added to the project or if I should just patch my installs. I can raise a PR, I'm just not sure the best place to add them. Any thoughts?
The text was updated successfully, but these errors were encountered: