Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update flask-caching version to 2.0+ to avoid breaking redis cache #25339

Closed
3 tasks done
ggbaro opened this issue Sep 19, 2023 · 2 comments · Fixed by #25947
Closed
3 tasks done

Update flask-caching version to 2.0+ to avoid breaking redis cache #25339

ggbaro opened this issue Sep 19, 2023 · 2 comments · Fixed by #25947

Comments

@ggbaro
Copy link
Contributor

ggbaro commented Sep 19, 2023 •
edited
Loading

A clear and concise description of what the bug is.

How to reproduce the bug

If we have flask-caching=~1.11.1 and cachelib>=9 (flask-caching did not pin down cahcelib dependency until 2.0, so it's very likely to happen...), we end up with this pallets-eco/flask-caching#381

caused by this very line:
https://github.com/pallets-eco/flask-caching/blob/ac13e01baa11d65c68dcba64f99ccaafd9b5419c/src/flask_caching/backends/rediscache.py#L62

The fix might be as small as this (even if I'd like to test more in depth): ggbaro@185e59e
Do you suggest to make a PR?

Expected results

App starts normally

Actual results

flask-caching breaks with redis cache

Environment

(please complete the following information):

  • browser type and version:
  • superset version: >=2
  • python version: 3.9 & 3.10

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@lf-floriandin
Copy link

Having the same issue and seen the issue in the Slack.
Hopefully there will be a fix soon

@ggbaro
Copy link
Contributor Author

ggbaro commented Sep 20, 2023 •
edited
Loading

Having the same issue and seen the issue in the Slack.

Hopefully there will be a fix soon

@lf-floriandin in the meantime, just add cachelib<9 to your local dependencies

ggbaro added a commit to ggbaro/superset-ggbaro that referenced this issue Nov 10, 2023
@ggbaro
fix: update flask-caching to avoid breaking redis cache, solves apach…
efbc5a7 
…e#25339
@ggbaro ggbaro mentioned this issue Nov 10, 2023
Merged
9 tasks
john-bodley pushed a commit that referenced this issue Nov 11, 2023
@ggbaro @villebro
fix: update flask-caching to avoid breaking redis cache, solves #25339 (
d95c200 
#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
michael-s-molina pushed a commit that referenced this issue Nov 16, 2023
@ggbaro @villebro @michael-s-molina
fix: update flask-caching to avoid breaking redis cache, solves #25339 (
a7fbdd6 
#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
saghatelian added a commit to 10webio/superset that referenced this issue Nov 27, 2023
@saghatelian @giftig
@Khrol @Always-prog @dpgaspar @rtexelm @geido @betodealmeida @justinpark @eschutho @john-bodley @michael-s-molina @mapledan @SA-Ark @Antonio-RiveroMartnez @kgabryje @FGrobelny @ggbaro @villebro @hughhhh @josedev-union @yousoph @jfrag1
3.0 (#3)
8651b24 
* fix(sqllab): reinstate "Force trino client async execution" (apache#25680)

* fix: remove unnecessary redirect (apache#25679)

(cherry picked from commit da42bf2)

* fix(chore): dashboard requests to database equal the number of slices it has (apache#24709)

(cherry picked from commit 75a7431)

* fix: bump to FAB 4.3.9 remove CSP exception (apache#25712)

(cherry picked from commit 8fb0c8d)

* fix(horizontal filter label): show full tooltip with ellipsis (apache#25732)

(cherry picked from commit e4173d9)

* fix: Revert "fix(Charts): Set max row limit + removed the option to use an empty row limit value" (apache#25753)

(cherry picked from commit e2fe967)

* fix: dataset update uniqueness (apache#25756)

(cherry picked from commit c7f8d11)

* fix(sqllab): slow pop datasource query (apache#25741)

(cherry picked from commit 2a2bc82)

* fix: allow for backward compatible errors (apache#25640)

* fix: DB-specific quoting in Jinja macro (apache#25779)

(cherry picked from commit 5659c87)

* fix: Revert "fix: Apply normalization to all dttm columns (apache#25147)" (apache#25801)

* fix: Resolve issue apache#24195 (apache#25804)

(cherry picked from commit 8737a8a)

* fix(SQL field in edit dataset modal): display full sql query (apache#25768)

(cherry picked from commit 1eba712)

* fix(sqllab): infinite fetching status after results are landed (apache#25814)

(cherry picked from commit 3f28eeb)

* fix: Fires onChange when clearing all values of single select (apache#25853)

(cherry picked from commit 8061d5c)

* fix: the temporal x-axis results in a none time_range. (apache#25429)

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
(cherry picked from commit ae619b1)

* fix(table chart): Show Cell Bars correctly apache#25625 (apache#25707)

(cherry picked from commit 916f7bc)

* fix: remove `update_charts_owners` (apache#25843)

* fix(charts): Time grain is None when dataset uses Jinja (apache#25842)

(cherry picked from commit 7536dd1)

* fix: Saving Mixed Chart with dashboard filter applied breaks adhoc_filter_b (apache#25877)

(cherry picked from commit 268c1dc)

* fix: database version field (apache#25898)

(cherry picked from commit 06ffcd2)

* fix: trino cursor (apache#25897)

(cherry picked from commit cdb18e0)

* chore: Updates CHANGELOG.md for 3.0.2

* fix(trino): allow impersonate_user flag to be imported (apache#25872)

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
(cherry picked from commit 458be8c)

* fix(table): Double percenting ad-hoc percentage metrics (apache#25857)

(cherry picked from commit 784a478)

* fix(sqllab): invalid sanitization on comparison symbol (apache#25903)

(cherry picked from commit 581d3c7)

* fix: update flask-caching to avoid breaking redis cache, solves apache#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* fix: always denorm column value before querying values (apache#25919)

* chore(colors): Updating Airbnb brand colors (apache#23619)

(cherry picked from commit 6d8424c)

* fix: naming denomalized to denormalized in helpers.py (apache#25973)

(cherry picked from commit 5def416)

* fix(helm): Restart all related deployments when bootstrap script changed (apache#25703)

* fix(rls): Update text from tables to datasets in RLS modal (apache#25997)

(cherry picked from commit 210f1f8)

* fix: Make Select component fire onChange listener when a selection is pasted in (apache#25993)

(cherry picked from commit 5fccf67)

* fix(explore): redandant force param (apache#25985)

(cherry picked from commit e7a1876)

* chore: Optimize fetching samples logic (apache#25995)

(cherry picked from commit 326ac4a)

* fix(native filters): rendering performance improvement by reduce overrendering (apache#25901)

(cherry picked from commit e1d73d5)

* fix: update FAB to 4.3.10, Azure user info fix (apache#26037)

(cherry picked from commit 628cd34)

* chore: Updates CHANGELOG.md for 3.0.2 (rc2)

---------

Co-authored-by: Rob Moore <giftig@users.noreply.github.com>
Co-authored-by: Igor Khrol <igor.khrol@automattic.com>
Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com>
Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Ross Mabbett <92495987+rtexelm@users.noreply.github.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: mapledan <mapledan829@gmail.com>
Co-authored-by: Arko <90512504+SA-Ark@users.noreply.github.com>
Co-authored-by: Antonio Rivero <38889534+Antonio-RiveroMartnez@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
Co-authored-by: FGrobelny <150029280+FGrobelny@users.noreply.github.com>
Co-authored-by: Giacomo Barone <46573388+ggbaro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: josedev-union <70741025+josedev-union@users.noreply.github.com>
Co-authored-by: yousoph <sophieyou12@gmail.com>
Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>
josedev-union pushed a commit to Ortege-xyz/studio that referenced this issue Jan 22, 2024
@ggbaro @villebro @josedev-union
fix: update flask-caching to avoid breaking redis cache, solves apach…
cdd7144 
…e#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this issue Mar 6, 2024
@ggbaro @villebro
fix: update flask-caching to avoid breaking redis cache, solves apach…
bae6636 
…e#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
sfirke pushed a commit to sfirke/superset that referenced this issue Mar 22, 2024
@ggbaro @villebro @sfirke
fix: update flask-caching to avoid breaking redis cache, solves apach…
3f52ce5 
…e#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this issue Nov 11, 2024
@ggbaro @villebro
fix: update flask-caching to avoid breaking redis cache, solves apach…
9d9546f 
…e#25339 (apache#25947)

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update flask-caching to avoid breaking redis cache, solves #25339 ggbaro/superset-ggbaro
2 participants
@ggbaro @lf-floriandin