chore: Deprecating ENABLE_FLASK_COMPRESS #10233
Conversation
john-bodley
force-pushed
the
john-bodley--deprecate-enable-flask-request
branch
from
f116c97 to
94ada9d
Compare
| @@ -228,7 +228,7 @@ Note that the development web | |||
| server (`superset run` or `flask run`) is not intended for production use. | |||
|
|
|||
| If not using gunicorn, you may want to disable the use of flask-compress | |||
| by setting `ENABLE_FLASK_COMPRESS = False` in your `superset_config.py` | |||
| by setting `COMPRESS_REGISTER = False` in your `superset_config.py` | |||
There was a problem hiding this comment.
maybe add COMPRESS_REGISTER to the config.py
I tend to use the config.py as a documentation for the available configuration options.
and add the link in the comments: https://github.com/colour-science/flask-compress
There was a problem hiding this comment.
@bkyryliuk historically config.py hasn't enumerated all the various Flask configs but rather only defines those which differ from the defaults.
|
LGTM. More generally, I'm wondering if it makes sense to avoid doing too much on the Flask app config and instructing people to use I'm pro having good default, but generally against having the burden of resurfacing / managing all those options... |
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This PR reverts the logic in #4617 as the Flask-Compress extension includes a
COMPRESS_REGISTERoption (default isTrue) which enables or disables compression when the extension is initialized.TEST PLAN
CI.
ADDITIONAL INFORMATION