-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: allow creating option in table select in dataset add modal #10369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10369 +/- ##
==========================================
+ Coverage 69.70% 70.45% +0.74%
==========================================
Files 196 603 +407
Lines 18950 32431 +13481
Branches 0 3294 +3294
==========================================
+ Hits 13210 22848 +9638
- Misses 5740 9477 +3737
- Partials 0 106 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ae7f6c1
to
02135ec
Compare
…aset add modal (apache#10369) (cherry picked from commit 09dfbab)
…aset add modal (apache#10369) (cherry picked from commit 09dfbab)
SUMMARY
There is currently an issue with adding google sheets as datasets. The dataset add modal expects there to be a schema selected before table select is enabled. Since google sheets don't have schemas there is no way to add a google sheet as a dataset. The fix is:
Trade Offs: there will now be a higher possibility for errors as users will be able to submit the form without shema and the table option now allows input so users can paste non-existent tables into the select field. Long term we should consider an api that can tell us if a database 1. supports schemas, 2. allows free-form table inputs
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
ENABLE_REACT_CRUD_VIEWS
flag)