Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Updating Dockerfile to work with updated python requirements. #10550

Merged
merged 6 commits into from
Aug 9, 2020

Conversation

craig-rueda
Copy link
Member

@craig-rueda craig-rueda commented Aug 7, 2020

SUMMARY

Recently, a change to Python's requirements files was made which introduced pip-compile-multi. This change moves all of the requirements*.txt files to a requirements folder located in the root of the repo. This change fixes up the Dockerfile to work correctly around this.

  • Updates the Dockerfile to work properly
  • Adds new requirements file for (local) docker images
  • Adds CI check to validate the Dockerfile

Fixes #10149

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #10550 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10550      +/-   ##
==========================================
- Coverage   63.70%   63.69%   -0.02%     
==========================================
  Files         767      767              
  Lines       36283    36283              
  Branches     3430     3430              
==========================================
- Hits        23115    23109       -6     
- Misses      13054    13057       +3     
- Partials      114      117       +3     
Flag Coverage Δ
#cypress 54.12% <ø> (-0.20%) ⬇️
#javascript 59.88% <ø> (ø)
#python 59.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.js 33.33% <0.00%> (-16.67%) ⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 77.27% <0.00%> (-5.20%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 44.00% <0.00%> (-4.00%) ⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 88.57% <0.00%> (-2.86%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.25% <0.00%> (-2.36%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 37.75% <0.00%> (-1.66%) ⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 52.12% <0.00%> (-1.22%) ⬇️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 55.91% <0.00%> (-1.08%) ⬇️
...t-frontend/src/dashboard/actions/dashboardState.js 59.33% <0.00%> (+1.33%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 84.94% <0.00%> (+2.15%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb051e9...86428c9. Read the comment docs.

@craig-rueda craig-rueda merged commit 5a908d4 into apache:master Aug 9, 2020
@craig-rueda craig-rueda deleted the fix/docker-requirements branch August 9, 2020 01:56
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
…pache#10550)

* Updating Dockerfile to work with updated python requirements.

* Adding a Docker build step to CI workflow

* Trying docker build-push

* Linting Dockerfile-dev

* Switching to dev dockerfile
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…pache#10550)

* Updating Dockerfile to work with updated python requirements.

* Adding a Docker build step to CI workflow

* Trying docker build-push

* Linting Dockerfile-dev

* Switching to dev dockerfile
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default credential not working
4 participants