fix: dashboard extra filters #10692
Merged
fix: dashboard extra filters #10692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--fix-build-extra-filters
branch
2 times, most recently
from
b6d6453 to
a0447ca
Compare
john-bodley
force-pushed
the
john-bodley--fix-build-extra-filters
branch
from
a0447ca to
d88caa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #10692 +/- ##
==========================================
- Coverage 64.31% 61.35% -2.97%
==========================================
Files 786 426 -360
Lines 36924 13788 -23136
Branches 3514 3533 +19
==========================================
- Hits 23746 8459 -15287
+ Misses 13069 5142 -7927
- Partials 109 187 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--fix-build-extra-filters
branch
from
d88caa3 to
c29b4f3
Compare
john-bodley
force-pushed
the
john-bodley--fix-build-extra-filters
branch
from
c29b4f3 to
fb18575
Compare
|
Add a little context: this function |
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
villebro
pushed a commit
that referenced
this pull request
Sep 11, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes an issue which may have been introduced in #10359 which allowed for the
==operator for extra filters however the logic for building the filters from a warming perspective were not updated resulting in a cache miss.The fix is to fetch the filter metadata and use the
==operator (and a corresponding scalar value) for non-multiple selections.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Updated the unit tests.
ADDITIONAL INFORMATION