-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: superset alerting misc fixes #10891
Conversation
cecfd46
to
8931466
Compare
Codecov Report
@@ Coverage Diff @@
## master #10891 +/- ##
==========================================
+ Coverage 59.15% 59.32% +0.17%
==========================================
Files 778 778
Lines 37123 37103 -20
Branches 3310 3310
==========================================
+ Hits 21959 22013 +54
+ Misses 14973 14904 -69
+ Partials 191 186 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Let's get some tests around these fixes. |
8931466
to
f243e99
Compare
good reminder :) added the test |
This reverts commit c3f1720.
* Superset alerting misc fixes * Test 0 threshold Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
This reverts commit 7d09e4d.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:


After:


TEST PLAN