docs: don't link to database engine pages #11242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11242 +/- ##
==========================================
+ Coverage 61.39% 65.56% +4.16%
==========================================
Files 832 832
Lines 39390 39394 +4
Branches 3592 3592
==========================================
+ Hits 24184 25829 +1645
+ Misses 15025 13456 -1569
+ Partials 181 109 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
docs/src/pages/index.tsx
Outdated
| </ul> | ||
| <span className="databaseSub"> | ||
| ... and any other | ||
| <a href="https://superset.incubator.apache.org/installation.html#database-dependencies"> |
There was a problem hiding this comment.
Can we update this link to https://superset.apache.org/docs/databases/installing-database-drivers as well?
There was a problem hiding this comment.
Seems perfectly reasonable to me. Making the change on behalf of @mistercrunch - feel free to roll it back if you're not into it ;)
|
Excited to see this one go through, @mistercrunch so I made the edit @ktmud suggested, and fixed up the linting so it'll pass CI. |
|
Merged! thanks you 2! |
* docs: don't link to database engine pages * making the linter happy * updating database installation link Co-authored-by: Evan Rusackas <evan@preset.io>
mistercrunch
added
🏷️ bot
Per ASF raised concerned, removing links to database pages from our main docs page