fix: Datetime popover issues #11621
Merged
fix: Datetime popover issues #11621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rusackas Can you take a look? What do you think about using |
Codecov Report
@@ Coverage Diff @@
## master #11621 +/- ##
=======================================
Coverage 62.26% 62.26%
=======================================
Files 873 873
Lines 42238 42238
Branches 3959 3959
=======================================
Hits 26301 26301
Misses 15757 15757
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Nov 9, 2020
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 0c6aeef)
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes issues described in #11609 and #11601.
I fixed the overflowing calendar issue by overriding tabs overflow styles in the popover. I don't think it's a perfect solution, because if the content of the tab changes to something that would actually require overflow, we'll need to do some workarounds.
I tried to render the calendar in a Portal (using
renderViewprop), outside of nodes withoverflow: hidden, but react-datetime doesn't work well with portals - the calendar view relies on its parent's css class, so we can't mount it in a different place.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see linked issues
After:
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc, @graceguo-supercat, @mistercrunch