[redux] move some redux utils to shared file #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
reviewed
Sep 21, 2016
| @@ -1,6 +1,8 @@ | |||
| import shortid from 'shortid'; | |||
| import * as actions from './actions'; | |||
| import { now } from '../modules/dates'; | |||
| import { addToObject, alterInObject, alterInArr, removeFromArr, getFromArr, addToArr } | |||
There was a problem hiding this comment.
we don't need trailing commas in destructured vars afaik.
There was a problem hiding this comment.
nvm, you are right: https://codeclimate.com/github/airbnb/caravel/pull/1164
There was a problem hiding this comment.
interesting tho, eslint complains that trailing comma is not needed here. where does codeclimate get it's js lint rules from? @bkyryliuk
There was a problem hiding this comment.
@ascott - .codeclimate.yml
It uses:
eslint:
enabled: true
config:
config: caravel/assets/.eslintrc
|
Looks good, thanks for the refactoring ! |
added 2 commits
September 21, 2016 21:17
|
going to ignore code climate failure for now since eslint complains when adding a trailing comma to a list of destructured vars. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. **This update includes a security fix.** - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.2...5.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. **This update includes a security fix.** - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.2...5.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. **This update includes a security fix.** - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.2...5.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Bumps [ws](https://github.com/websockets/ws) from 5.2.2 to 5.2.3. **This update includes a security fix.** - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.2...5.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's us share some common redux utils with the new explore refactor
@vera-liu @mistercrunch @bkyryliuk