-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: handle context-dependent feature flags in CLI #12088
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12088 +/- ##
==========================================
- Coverage 67.26% 63.69% -3.58%
==========================================
Files 959 959
Lines 47241 47232 -9
Branches 4629 4629
==========================================
- Hits 31778 30083 -1695
- Misses 15345 16965 +1620
- Partials 118 184 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
539ad3b
to
92f9f43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...
SUMMARY
@ktmud pointed out in #11803 that
GET_FEATURE_FLAG_FUNC
might use the app context, breaking the CLI. This PR fixes it.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Added this to my
superset_config.py
:The CLI works as expected.
ADDITIONAL INFORMATION