Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: timezone editor #16281

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Aug 16, 2021

SUMMARY

This adds timezone into the report payload.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-16.at.6.50.08.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #16281 (9c42824) into master (36bc7b0) will decrease coverage by 0.14%.
The diff coverage is 46.73%.

❗ Current head 9c42824 differs from pull request most recent head 82f5aef. Consider uploading reports for the commit 82f5aef to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16281      +/-   ##
==========================================
- Coverage   76.64%   76.49%   -0.15%     
==========================================
  Files         997      997              
  Lines       53246    53247       +1     
  Branches     6777     6778       +1     
==========================================
- Hits        40808    40731      -77     
- Misses      12208    12286      +78     
  Partials      230      230              
Flag Coverage Δ
hive ?
javascript 70.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ReportModal/index.tsx 72.63% <0.00%> (-0.78%) ⬇️
...otation_layers/annotations/commands/bulk_delete.py 88.46% <0.00%> (ø)
...t/annotation_layers/annotations/commands/create.py 86.66% <0.00%> (ø)
...t/annotation_layers/annotations/commands/delete.py 85.18% <0.00%> (ø)
...t/annotation_layers/annotations/commands/update.py 88.23% <0.00%> (ø)
superset/annotation_layers/annotations/dao.py 85.18% <0.00%> (ø)
superset/annotation_layers/annotations/schemas.py 86.66% <0.00%> (ø)
superset/annotation_layers/commands/bulk_delete.py 85.71% <0.00%> (ø)
superset/annotation_layers/commands/create.py 90.32% <0.00%> (ø)
superset/annotation_layers/commands/delete.py 89.65% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bc7b0...82f5aef. Read the comment docs.

@eschutho eschutho merged commit f5fbfef into apache:master Aug 17, 2021
@eschutho eschutho deleted the ch22338_gmtReportSchedule branch August 17, 2021 16:32
betodealmeida pushed a commit to preset-io/superset that referenced this pull request Aug 17, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
(cherry picked from commit f5fbfef)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants