Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(docker): add ecpg to docker image #16566

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 2, 2021

SUMMARY

When enabling the Postgres validator, the docker-compose returns the following error:
image

After adding libecpq-dev to the "Final lean image" (which is also installed on the pip install image), the Postgres query validator works correctly:
image

TESTING INSTRUCTIONS

  1. add the following feature flag to docker/pythonpath_dev/superset_config_docker.py:
FEATURE_FLAGS = {
    "SQL_VALIDATORS_BY_ENGINE": {"postgresql": "PostgreSQLValidator"},
}
  1. Run docker-compose up
  2. Open SQL Lab and write an incorrect query
  3. See the validator raise an error correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@villebro villebro merged commit 9cfce64 into apache:master Nov 17, 2021
@villebro villebro deleted the villebro/libecpg branch November 17, 2021 10:23
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants