-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add Databricks ODBC engine spec #16862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16862 +/- ##
==========================================
- Coverage 77.00% 76.77% -0.23%
==========================================
Files 1018 1021 +3
Lines 54654 54733 +79
Branches 7454 7454
==========================================
- Hits 42086 42022 -64
- Misses 12324 12467 +143
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see support added for the new SQL endpoints! 💯 One minor optional nit/comment, other than that LGTM
engine_name = "Databricks" | ||
engine_name = "Databricks (Hive)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: to avoid confusion, maybe this should be "Databricks (PyHive)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked with Eugenia and she suggested "Databricks Interactive Cluster" here, and "Databricks SQL Endpoint" for ODBC.
* feat: add Databricks ODBC engine spec * Rename Databricks specs
* feat: add Databricks ODBC engine spec * Rename Databricks specs
@betodealmeida This feature is not available in latest superset pypi package - apache-superset 1.3.2 |
@eschutho is currently working on getting 1.4.0 out, which should include this engine spec. Unfortunately we just found out a bug with 1.4.0rc3 and we're going to have to do an RC4, so it should take another couple of weeks. |
SUMMARY
Add an ODBC based Databricks DB engine spec. This allows Superset to connect to the new SQL endpoints.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I was able to connect Superset to a Databricks cluster via ODBC, as well as to a SQL endpoint.
The steps to reproduce:
ADDITIONAL INFORMATION