Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(pylint): Add context about disablement of Pylint messages #17016

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

john-bodley
Copy link
Member

SUMMARY

As titled. Until we can find an automated mechanism to prevent people from adding top-level Pylint disablement, our current best solution is to document the desired pattern.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API


```bash
# for python
tox -e pylint
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously wrong as the entire section was a code block.

@john-bodley john-bodley changed the title doc(pylint): Adding context about disablement of Pylint messages docs(pylint): Adding context about disablement of Pylint messages Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #17016 (9e8a782) into master (c471a85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17016   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files        1030     1030           
  Lines       55086    55086           
  Branches     7478     7478           
=======================================
  Hits        42339    42339           
  Misses      12496    12496           
  Partials      251      251           
Flag Coverage Δ
hive 81.47% <ø> (ø)
javascript 70.89% <ø> (ø)
mysql 81.92% <ø> (ø)
postgres 81.93% <ø> (ø)
python 82.28% <ø> (ø)
sqlite 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c471a85...9e8a782. Read the comment docs.

@john-bodley john-bodley changed the title docs(pylint): Adding context about disablement of Pylint messages docs(pylint): Add context about disablement of Pylint messages Oct 7, 2021
@john-bodley john-bodley merged commit 9ef2861 into master Oct 7, 2021
@john-bodley john-bodley deleted the john-bodley-patch-3 branch October 7, 2021 17:38
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants