Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Breaks the dataViewCommon folder into TableCollection and Pagination folders #17132

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Previously we had two components inside the dataViewCommon folder (TableCollection and Pagination). Both were migrated to their corresponding folders. We already had a Pagination folder so I merged the file structure.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #17132 (b302c91) into master (e055e59) will not change coverage.
The diff coverage is 91.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17132   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1031     1030    -1     
  Lines       55229    55229           
  Branches     7516     7516           
=======================================
  Hits        42496    42496           
  Misses      12482    12482           
  Partials      251      251           
Flag Coverage Δ
javascript 70.92% <91.17%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/TableCollection/index.tsx 100.00% <ø> (ø)
...erset-frontend/src/components/Pagination/index.tsx 72.72% <70.00%> (-27.28%) ⬇️
...rset-frontend/src/components/ListView/ListView.tsx 96.33% <100.00%> (+0.03%) ⬆️
...set-frontend/src/components/Pagination/Wrapper.tsx 100.00% <100.00%> (ø)
...et-frontend/src/components/TableView/TableView.tsx 94.59% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e055e59...b302c91. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 4c96ae7 into apache:master Oct 25, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants