-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(Dashboard): Sidepanel positioning #17200
fix(Dashboard): Sidepanel positioning #17200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17200 +/- ##
==========================================
+ Coverage 76.94% 77.06% +0.12%
==========================================
Files 1039 1037 -2
Lines 55580 55671 +91
Branches 7575 7607 +32
==========================================
+ Hits 42764 42904 +140
+ Misses 12566 12517 -49
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor bycatch related to a variable used here. LGTM and works great in testing, but would really prefer to get @michael-s-molina or @kgabryje to sign off on the styling part.
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
Outdated
Show resolved
Hide resolved
/testenv up |
@pkdotson Ephemeral environment spinning up at http://54.185.33.35:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Ephemeral environment shutdown and build artifacts deleted. |
* Refactor * Adjust top offset * Calculate padding chart list * Check for standalone mode * Rename standaloneMode
SUMMARY
This PR fixes several positioning issues with the sidepanel in Dashboard.
Fixes #17158
BEFORE
See #17158
AFTER
Video.Game.Sales.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION