Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove variables from styled component #17228

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Oct 26, 2021

SUMMARY

This pr remove less vars from styled component in the dashboard builder and hovermenu

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-10-25.at.9.36.15.PM.mov

TESTING INSTRUCTIONS

Go to dashboard builder and check that styles are applied when user hovers over row within and column or row within tabs.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #17228 (7cbbca4) into master (ef01cbb) will increase coverage by 0.14%.
The diff coverage is 95.14%.

❗ Current head 7cbbca4 differs from pull request most recent head 43cc98b. Consider uploading reports for the commit 43cc98b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17228      +/-   ##
==========================================
+ Coverage   76.82%   76.97%   +0.14%     
==========================================
  Files        1038     1037       -1     
  Lines       55597    55635      +38     
  Branches     7585     7594       +9     
==========================================
+ Hits        42715    42825     +110     
+ Misses      12632    12560      -72     
  Partials      250      250              
Flag Coverage Δ
javascript 71.03% <94.94%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 92.35% <ø> (ø)
...nd/src/dashboard/components/nativeFilters/types.ts 100.00% <ø> (ø)
...perset-frontend/src/explore/components/Control.tsx 76.47% <ø> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx 6.84% <0.00%> (-0.20%) ⬇️
...nts/controls/ConditionalFormattingControl/types.ts 100.00% <ø> (ø)
...ontend/src/filters/components/Select/buildQuery.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupColors.ts 100.00% <ø> (ø)
superset/annotation_layers/schemas.py 100.00% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 94.87% <88.88%> (-5.13%) ⬇️
...et-frontend/src/dashboard/components/Dashboard.jsx 81.88% <100.00%> (+3.79%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef01cbb...43cc98b. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkdotson it appears you might have some to remove from this file too superset-frontend/src/dashboard/components/menu/HoverMenu.tsx. Thanks!

@pkdotson pkdotson requested a review from geido October 27, 2021 20:00
@pkdotson pkdotson merged commit 9a4ab10 into apache:master Nov 2, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* remove variables

* fix hovermenu styles
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants