Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: bump to superset-ui 0.18.15 #17232

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 26, 2021

SUMMARY

This PR contains

  1. import es module from "@superset-ui/core" instead of CommonJS module
  2. bump to superset-ui 0.18.15

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #17232 (456563d) into master (ef01cbb) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17232   +/-   ##
=======================================
  Coverage   76.82%   76.83%           
=======================================
  Files        1038     1038           
  Lines       55597    55612   +15     
  Branches     7585     7590    +5     
=======================================
+ Hits        42715    42728   +13     
- Misses      12632    12634    +2     
  Partials      250      250           
Flag Coverage Δ
javascript 71.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/filters/components/Select/buildQuery.ts 100.00% <ø> (ø)
superset-frontend/src/setup/setupColors.ts 100.00% <ø> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx 6.84% <0.00%> (-0.20%) ⬇️
superset-frontend/src/components/Select/Select.tsx 92.35% <0.00%> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.17% <0.00%> (ø)
...et-frontend/src/dashboard/components/Dashboard.jsx 81.88% <0.00%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef01cbb...456563d. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit dbf5225 into apache:master Oct 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants