fix: failed timezone selector UT #17370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
force-pushed
the
fix_timezoneUT
branch
from
e1747dc to
2d046b6
Compare
9 tasks
zhaoyongjie
commented
Nov 8, 2021
Comment on lines
-57
to
+63
| const selection = await screen.findByTitle('GMT -06:00 (America/Belize)'); | ||
|
|
||
| const isDaylight = moment('now').isDST(); | ||
| let findTitle = 'GMT -07:00 (Mountain Standard Time)'; | ||
| if (isDaylight) { | ||
| findTitle = 'GMT -06:00 (Mountain Daylight Time)'; | ||
| } | ||
| const selection = await screen.findByTitle(findTitle); |
There was a problem hiding this comment.
we should coverage "offsetsToName" in src/components/TimezoneSelector/index.tsx
Codecov Report
@@ Coverage Diff @@
## master #17370 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 1036 1036
Lines 55759 55759
Branches 7628 7628
=======================================
Hits 42892 42892
Misses 12611 12611
Partials 256 256
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
currently, frontend CI is blocked by timezone selector UT. We should get Standard Time or Daylight Time in the test case.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION