-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add main datetime column to dataset editor #17739
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17739 +/- ##
==========================================
+ Coverage 68.06% 68.13% +0.07%
==========================================
Files 1653 1653
Lines 66374 66379 +5
Branches 7121 7121
==========================================
+ Hits 45177 45227 +50
+ Misses 19300 19255 -45
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@betodealmeida Ephemeral environment spinning up at http://35.88.163.205:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 😁
Ephemeral environment shutdown and build artifacts deleted. |
* feat: add main dttm col to dataset editor * Add tests
* feat: add main dttm col to dataset editor * Add tests
SUMMARY
For feature parity with the old CRUD dataset editor, modify the dataset editor to allow specifying a main datetime column.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
Only temporal columns can be selected as a default datetime. The radio button is disabled when the column is not marked as temporal.
TESTING INSTRUCTIONS
cleaned_sales_data
dataset and set a different column as the default datetime. Save.ADDITIONAL INFORMATION