Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(monorepo): update plugin dependencies #17837

Merged
merged 5 commits into from
Dec 22, 2021
Merged

refactor(monorepo): update plugin dependencies #17837

merged 5 commits into from
Dec 22, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Dec 21, 2021 •
edited
Loading

SUMMARY

  1. use local dependencies replace with the version dependencies in package.json
  2. fix release workflow

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

zhaoyongjie
zhaoyongjie commented Dec 21, 2021
View reviewed changes
superset-frontend/scripts/lernaVersion.sh
message="chore: publish $tag"

# Update the lock file here
rm "$rootDir/package-lock.json"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to update lock file when use file dependencies in packages.json

@codecov
Copy link

codecov bot commented Dec 21, 2021 •
edited
Loading

Codecov Report

Merging #17837 (4a894be) into master (19daf65) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17837      +/-   ##
==========================================
- Coverage   67.03%   66.98%   -0.06%     
==========================================
  Files        1608     1609       +1     
  Lines       64817    64865      +48     
  Branches     6852     6863      +11     
==========================================
- Hits        43451    43450       -1     
- Misses      19507    19551      +44     
- Partials     1859     1864       +5
Flag Coverage Δ
javascript 53.77% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/dashboard/util/replaceUndefinedByNull.ts 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/menu/ShareMenuItems/index.tsx 81.25% <0.00%> (-18.75%) ⬇️
superset-frontend/src/dataMask/reducer.ts 50.00% <0.00%> (-16.67%) ⬇️
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 55.55% <0.00%> (-15.88%) ⬇️
...src/dashboard/components/DashboardBuilder/utils.ts 81.81% <0.00%> (-9.10%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 82.83% <0.00%> (-1.72%) ⬇️
...rontend/src/dashboard/containers/DashboardPage.tsx 25.24% <0.00%> (-1.64%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 80.90% <0.00%> (-0.91%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 61.11% <0.00%> (-0.43%) ⬇️
...t-frontend/src/dashboard/actions/dashboardState.js 35.39% <0.00%> (-0.41%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19daf65...4a894be. Read the comment docs.

@zhaoyongjie zhaoyongjie requested a review from villebro December 21, 2021 07:04
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 21, 2021
@zhaoyongjie zhaoyongjie changed the title refactor(monorepo): update lock file refactor(monorepo): update plugin dependencies Dec 21, 2021
villebro
villebro approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor nit

@zhaoyongjie zhaoyongjie merged commit 9840fbf into apache:master Dec 22, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@zhaoyongjie @shcoderAlex
refactor(monorepo): update plugin dependencies (apache#17837)
12faa12 
* refactor(monorepo): use local dependencies in packages.json

* add prettier ignore

* update commit message

* fix release workflow

* refine release script
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@zhaoyongjie @bwang221
refactor(monorepo): update plugin dependencies (apache#17837)
b74d420 
* refactor(monorepo): use local dependencies in packages.json

* add prettier ignore

* update commit message

* fix release workflow

* refine release script
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoyongjie @villebro @mistercrunch